Merge branch 'refactor-review' of https://bitbucket.org/flucoma/flucoma-supercollider into refactor-review

include/FluidSCWrapper.hpp

@@ -125,6 +125,7 @@ public:
   {
     mControlsIterator.reset(mInBuf + 1); //mClient.audioChannelsIn());
     Wrapper::setParams(mParams, mWorld->mVerbosity > 0, mWorld, mControlsIterator); // forward on inputs N + audio inputs as params
+    mParams.template constrainParameterValues(); 
     const Unit *unit = this;
     for (int i = 0; i < mClient.audioChannelsIn(); ++i)
     {

release-packaging/Classes/FluidBufNoveltySlice.sc

@@ -1,13 +1,13 @@
 FluidBufNoveltySlice{
 		*process { arg server, srcBufNum, startAt = 0, nFrames = -1, startChan = 0, nChans = -1, indBufNum, kernSize = 3, thresh = 0.8, filtSize = 1, winSize = 1024, hopSize = -1, fftSize = -1;
 
-		var maxFFTSize = if (fftSize == -1) {winSize.nextPowerOfTwo} {fftSize};
+		//var maxFFTSize = if (fftSize == -1) {winSize.nextPowerOfTwo} {fftSize}; //ready for when we need it from the RT wrapper
 
 		if(srcBufNum.isNil) { Error("Invalid buffer").format(thisMethod.name, this.class.name).throw};
 		if(indBufNum.isNil) { Error("Invalid buffer").format(thisMethod.name, this.class.name).throw};
 
 		server = server ? Server.default;
 
-		server.sendMsg(\cmd, \BufNoveltySlice, srcBufNum, startAt, nFrames, startChan, nChans, indBufNum, kernSize, thresh, filtSize, winSize, hopSize, maxFFTSize);
+		server.sendMsg(\cmd, \BufNoveltySlice, srcBufNum, startAt, nFrames, startChan, nChans, indBufNum, kernSize, thresh, filtSize, winSize, hopSize, fftSize);
 	}
 }

release-packaging/Classes/FluidBufTransients.sc

@@ -7,9 +7,6 @@ FluidBufTransients {
 		transBufNum = transBufNum ? -1;
 		resBufNum = resBufNum ? -1;
 
-		("Source" + srcBufNum).postln;
-		("Trans" + transBufNum).postln;
-		("Res" + resBufNum).postln;
 		server.sendMsg(\cmd, \BufTransients, srcBufNum, startAt, nFrames, startChan, nChans, transBufNum, resBufNum, order, blockSize, padSize, skew, threshFwd, threshBack, winSize, debounce);
 	}
 }

release-packaging/HelpSource/Classes/FluidBufNoveltySlice.schelp

@@ -105,7 +105,7 @@ c = Buffer.new(s);
 )
 
 // process with a given filterSize
-FluidBufNoveltySlice.process(s,b.bufnum, indBufNum: c.bufnum, kernSize:31, thresh:0.35, filtSize:1)
+FluidBufNoveltySlice.process(s,b.bufnum, indBufNum: c.bufnum, kernSize:31, thresh:0.3, filtSize:0)
 
 //check the number of slices: it is the number of frames in the transBuf minus the boundary index.
 c.query;

release-packaging/HelpSource/Classes/FluidBufSines.schelp

@@ -42,7 +42,7 @@ ARGUMENT:: sineBufNum
 ARGUMENT:: resBufNum
 	The index of the buffer where the residual of the sinusoidal component will be reconstructed.
 
-ARGUMENT:: bandwidth
+ARGUMENT:: bw
 	The width in bins of the fragment of the fft window that is considered a normal deviation for a potential continuous sinusoidal track. It has an effect on CPU cost: the widest is more accurate but more computationally expensive.
 
 ARGUMENT:: thresh